feat: forward --plugin to JSS — serve a directory and mount apps (0.0.9) - #8
Merged
Merged
Conversation
servejss --plugin './chat/plugin.js@/chat' ./public serves the directory and mounts the app in one command. The value is forwarded verbatim to jss start --plugin (#594, JSS 0.0.217) — jsserve does no plugin parsing, keeping the How-it-works split: JSS owns loading and validation, the wrapper owns the CLI. Repeatable; mounts are listed on a new Plugins banner line. JSS floor raised to >=0.0.217 (the release with the flag), lockfile refreshed, version bumped to 0.0.9. README gains the option, a Static Site + Live App use case (with shell-quoting caveat for scoped packages), and the Output example catches up with the 0.0.8 banner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the plugin tie-in planned in JSS#592/#594.
What
servejss --plugin './chat/plugin.js@/chat' ./publicserves
./publicwith the usual read/write REST semantics and mounts the JSS app plugin at/chat— one command, no config file.--pluginvalue is forwarded verbatim tojss start --plugin(JSS 0.0.217, #594). jsserve does no plugin-spec parsing, consistent with the How-it-works contract: JSS owns loading and validation, the wrapper owns the CLI. Repeatable.Plugins:banner line lists the mounts.>=0.0.211→>=0.0.217, lockfile refreshed against the registry, version 0.0.9.Verified
Against registry-installed JSS 0.0.217: static
GETserves,PUT→ 201, plugin route answers on/hello-app/hello, banner showsMode: … (public, no auth)and thePlugins:line. Served directory stays clean (noindex.html/.acl;.plugins/only appears if a mounted plugin uses its storage API — thepluginDataDirfollow-up lives in JSS#592).